Remove default values for cache settings #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull Request Overview
This pull request removes default values for cache duration settings in the App Builder configuration library. Previously, when users didn't specify cache durations, the library provided default values (60 seconds for HTML, 604800 seconds for JS/CSS/images). Now, these fields will be undefined when not explicitly configured by the user, allowing downstream consumers to handle caching defaults themselves.
Key Changes:
- Removed default cache duration constants from the
defaultsobject - Updated cache duration assignment to not apply fallback values
- Updated test mock data to reflect
undefinedvalues for cache durations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/index.js |
Removed cache duration default constants and fallback logic; cache duration fields now directly assigned from user config without defaults |
test/data-mocks/config-loader.js |
Updated test mock configurations to set cache duration fields to undefined instead of numeric string values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pru55e11
approved these changes
Nov 14, 2025
shazron
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a non-breaking version of #42
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: